[v3-2-test] Sync default image Python version references (#64994)#65045
Merged
[v3-2-test] Sync default image Python version references (#64994)#65045
Conversation
* Sync default image Python version references * Fix mypy type error in _read_global_constants_assignment return type Since ast.literal_eval() returns Any, annotating the private helper as returning str | list[str] caused mypy errors in both callers: assigning the result to `list[str]` and returning it as `str`. Changing the return type to Any (which matches ast.literal_eval) resolves both without requiring casts. * Update scripts/ci/prek/common_prek_utils.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- (cherry picked from commit d212f62) Co-authored-by: DaveT1991 <129008657+DaveT1991@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
boring-cyborg
bot
added
area:dev-tools
area:production-image
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync default image Python version references
Fix mypy type error in _read_global_constants_assignment return type
Since ast.literal_eval() returns Any, annotating the private helper as
returning str | list[str] caused mypy errors in both callers: assigning
the result to
list[str]and returning it asstr. Changing the returntype to Any (which matches ast.literal_eval) resolves both without
requiring casts.
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com
(cherry picked from commit d212f62)
Co-authored-by: DaveT1991 129008657+DaveT1991@users.noreply.github.com
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com