Skip to content

[AIRFLOW-5853] BigQuery - standardize task_ids in example_dag#6505

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:bigquery-standarize-taskids-example-dag
Nov 7, 2019
Merged

[AIRFLOW-5853] BigQuery - standardize task_ids in example_dag#6505
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:bigquery-standarize-taskids-example-dag

Conversation

@TobKed
Copy link
Contributor

@TobKed TobKed commented Nov 5, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@TobKed TobKed force-pushed the bigquery-standarize-taskids-example-dag branch from 3458d40 to e4d1f13 Compare November 6, 2019 16:32
@TobKed TobKed force-pushed the bigquery-standarize-taskids-example-dag branch from e4d1f13 to 107ea35 Compare November 7, 2019 10:57
@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #6505 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6505      +/-   ##
=========================================
+ Coverage   83.69%   83.7%   +<.01%     
=========================================
  Files         635     635              
  Lines       36716   36716              
=========================================
+ Hits        30731   30734       +3     
+ Misses       5985    5982       -3
Impacted Files Coverage Δ
airflow/gcp/example_dags/example_bigquery.py 100% <ø> (ø) ⬆️
airflow/models/taskinstance.py 93.79% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bcbd48...107ea35. Read the comment docs.

@TobKed
Copy link
Contributor Author

TobKed commented Nov 7, 2019

CC @mik-laj

@potiuk potiuk merged commit 07e80e5 into apache:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants