fix: sync SearchBar input with updated defaultValue prop#65057
Open
bhumikasudarshani-cmd wants to merge 1 commit intoapache:mainfrom
Open
fix: sync SearchBar input with updated defaultValue prop#65057bhumikasudarshani-cmd wants to merge 1 commit intoapache:mainfrom
bhumikasudarshani-cmd wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
SearchBarcomponent initializes its internal state using thedefaultValueprop, but does not stay in sync whendefaultValuechanges after the initial render.This commonly happens when the search value is controlled via URL query parameters (e.g., in pages like DagsList, Connections, AssetsList). When navigation actions (such as back/forward) update the query params, the
defaultValueprop changes, but the input field does not reflect the updated value.Current behavior:
Expected behavior:
defaultValuechangesFix
Added
useEffectto watchdefaultValueand sync internal state:Also added
useEffectto the import statement.Testing
Updates input when defaultValue prop changesAffected Pages
Any page using
SearchBarwith URL-driven filters:Closes #65053