fix(ui): use fixed menu positioning for dropdowns in connection forms#65085
Open
tysoncung wants to merge 1 commit intoapache:mainfrom
Open
fix(ui): use fixed menu positioning for dropdowns in connection forms#65085tysoncung wants to merge 1 commit intoapache:mainfrom
tysoncung wants to merge 1 commit intoapache:mainfrom
Conversation
…apache#65007) - Add menuPosition="fixed" to FieldDropdown and FieldMultiSelect components - Ensures dropdown menus are fully visible when rendered inside accordion panels - Prevents menu clipping when parent containers have overflow constraints Closes apache#65007
tysoncung
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dropdown lists in custom connection parameter forms are not fully visible when rendered inside accordion panels. The dropdown menu gets clipped by the accordion container's overflow constraints, making some options inaccessible without a scrollbar.
Closes #65007
Solution
Added
menuPosition="fixed"prop to bothFieldDropdownandFieldMultiSelectcomponents. This ensures the dropdown menu is positioned relative to the viewport rather than its parent container, preventing clipping issues.Files Changed
airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldDropdown.tsx- Added menuPosition="fixed"airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldMultiSelect.tsx- Added menuPosition="fixed"Testing
This fix ensures dropdown menus remain fully visible and scrollable regardless of their parent container's overflow settings.