Fix OS detection in providers release vote script snippet#65116
Merged
jscheffl merged 1 commit intoapache:mainfrom Apr 13, 2026
Merged
Fix OS detection in providers release vote script snippet#65116jscheffl merged 1 commit intoapache:mainfrom
jscheffl merged 1 commit intoapache:mainfrom
Conversation
Use OSTYPE for macOS detection (the previous $OS variable was undefined) and replace placeholder values with TODO: prefixes so they're easier to spot.
potiuk
requested review from
bugraoz93,
jedcunningham,
jscheffl,
shahar1 and
vincbeck
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-2-test
eladkal
approved these changes
Apr 13, 2026
jscheffl
approved these changes
Apr 13, 2026
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Ha, AI Slop that was not validated as I do not own a (recent) Mac (mine is 15y old...) thanks for the fix!
jscheffl
removed
the
backport-to-v3-2-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-vote shell snippet in
dev/README_RELEASE_PROVIDERS.mdbranched on an undefined$OSvariable, so the macOS path was never taken. Switch toOSTYPEsodate -u -vis actually used on macOS, and rename the placeholder values toTODO:prefixes so they're easier to spot before sending the vote email.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.6) following the guidelines