[v3-2-test] Fix E2E Flaky Tests Report failing with gh api 404 (#65120)#65157
Merged
[v3-2-test] Fix E2E Flaky Tests Report failing with gh api 404 (#65120)#65157
Conversation
scripts/ci/analyze_e2e_flaky_tests.py builds 'gh api <endpoint> -f key=val ...' to list workflow runs. The gh CLI defaults to POST whenever -f parameters are present, so the workflow runs endpoint returned 'Not Found (HTTP 404)' and the script wrote no output file, causing the downstream slack-github-action step to crash with ENOENT on slack-message.json. Force --method GET in the gh_api helper and add a regression test. (cherry picked from commit 7ae29fb) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
3 tasks
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-2-test
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/ci/analyze_e2e_flaky_tests.py builds 'gh api -f
key=val ...' to list workflow runs. The gh CLI defaults to POST
whenever -f parameters are present, so the workflow runs endpoint
returned 'Not Found (HTTP 404)' and the script wrote no output file,
causing the downstream slack-github-action step to crash with ENOENT
on slack-message.json.
Force --method GET in the gh_api helper and add a regression test.
(cherry picked from commit 7ae29fb)
Co-authored-by: Jarek Potiuk jarek@potiuk.com