fix(ui): register trigger and sensor graph node types#65167
Open
windro-xdd wants to merge 6 commits intoapache:mainfrom
Open
fix(ui): register trigger and sensor graph node types#65167windro-xdd wants to merge 6 commits intoapache:mainfrom
windro-xdd wants to merge 6 commits intoapache:mainfrom
Conversation
Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.
9d8f6f5 to
8fe517c
Compare
Author
Screenshot (trigger + sensor nodes rendering)Added screenshot to this PR branch:
Preview: What this shows:
|
bbovenzi
reviewed
Apr 14, 2026
Author
|
Thanks for the review and for calling out the scope. I cleaned this PR so it only includes graphTypes.ts now.
The screenshot context came from the earlier closed PR discussion (#64689), where a screenshot had been requested. I kept that context in comments only, but removed non-essential files from this PR so the diff stays focused on the single file fix. |
bbovenzi
approved these changes
Apr 14, 2026
Contributor
|
Great. Thanks for working on this and for graciously responding to the reviews in your previous PR. |
Author
|
Thanks again for the review and guidance. I’m still getting used to the project workflow, and I really appreciate the patience and feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
triggerandsensornode type mappings in UI graph nodeTypes to avoid render failures when those node kinds appear in dependency graphsTesting
pnpm test src/components/Graph/graphTypes.test.tspnpm test src/components/Graphpnpm lintpnpm buildScreenshot
Screenshot added - DAG graph view showing proper rendering of trigger and sensor nodes with the fix applied. See comments below for details.
Supersedes #64689.
Closes #64621
Closes #49576