Skip to content

fix(ui): register trigger and sensor graph node types#65167

Open
windro-xdd wants to merge 6 commits intoapache:mainfrom
windro-xdd:fix-trigger-node-clean-v2
Open

fix(ui): register trigger and sensor graph node types#65167
windro-xdd wants to merge 6 commits intoapache:mainfrom
windro-xdd:fix-trigger-node-clean-v2

Conversation

@windro-xdd
Copy link
Copy Markdown

@windro-xdd windro-xdd commented Apr 13, 2026

Summary

  • Register missing trigger and sensor node type mappings in UI graph nodeTypes to avoid render failures when those node kinds appear in dependency graphs
  • Add focused unit test coverage for the new node type registrations
  • Keep scope intentionally minimal (no i18n or unrelated file changes)

Testing

  • pnpm test src/components/Graph/graphTypes.test.ts
  • pnpm test src/components/Graph
  • pnpm lint
  • pnpm build

Screenshot

Screenshot added - DAG graph view showing proper rendering of trigger and sensor nodes with the fix applied. See comments below for details.

Supersedes #64689.

Closes #64621
Closes #49576

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 13, 2026
Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.
@windro-xdd windro-xdd force-pushed the fix-trigger-node-clean-v2 branch from 9d8f6f5 to 8fe517c Compare April 13, 2026 18:31
@windro-xdd
Copy link
Copy Markdown
Author

Screenshot (trigger + sensor nodes rendering)

Added screenshot to this PR branch:

airflow-core/src/airflow/ui/src/components/Graph/trigger-sensor-graph-screenshot.png

Preview:

Trigger and sensor nodes graph screenshot

What this shows:

  • wait_sensor rendered as TimeDeltaSensor
  • trigger_next rendered as TriggerDagRunOperator
  • Graph view renders both node kinds without blanking/crashing

@windro-xdd windro-xdd marked this pull request as ready for review April 14, 2026 12:50
@bbovenzi bbovenzi added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 14, 2026
@bbovenzi bbovenzi added this to the Airflow 3.2.2 milestone Apr 14, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need this file

@windro-xdd
Copy link
Copy Markdown
Author

Thanks for the review and for calling out the scope.

I cleaned this PR so it only includes graphTypes.ts now.

  • Removed graphTypes.test.ts
  • Removed the committed screenshot file

The screenshot context came from the earlier closed PR discussion (#64689), where a screenshot had been requested. I kept that context in comments only, but removed non-essential files from this PR so the diff stays focused on the single file fix.

@bbovenzi
Copy link
Copy Markdown
Contributor

Great. Thanks for working on this and for graciously responding to the reviews in your previous PR.

@windro-xdd
Copy link
Copy Markdown
Author

Thanks again for the review and guidance. I’m still getting used to the project workflow, and I really appreciate the patience and feedback.

@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch type:bug-fix Changelog: Bug Fixes

Projects

None yet

3 participants