Prevent Session from staying opened between yields#65179
Prevent Session from staying opened between yields#65179pierrejeambrun merged 2 commits intoapache:mainfrom
Conversation
2a90f11 to
e65457d
Compare
e65457d to
a1142a4
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Cool! Looks much better, thanks for the discussion (in Slack)!
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py
Outdated
Show resolved
Hide resolved
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM +1
Nice investigation and thanks for sharing the clips, makes me a lot comfortable
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 9813bf5 v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
(cherry picked from commit 9813bf5)
Follow up of: #65162
Based on Jarek idea, move the opening and closing of the session within the yield loop so connection isn't being held open on until the full response is downloaded.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.