Skip to content

[AIRFLOW-5782] Migrate AWS Lambda to /providers/amazon/aws [AIP-21]#6518

Merged
potiuk merged 2 commits intoapache:masterfrom
shcherbin:airflow-5782-migrate-aws-lambda-to-providers
Nov 9, 2019
Merged

[AIRFLOW-5782] Migrate AWS Lambda to /providers/amazon/aws [AIP-21]#6518
potiuk merged 2 commits intoapache:masterfrom
shcherbin:airflow-5782-migrate-aws-lambda-to-providers

Conversation

@shcherbin
Copy link
Copy Markdown
Contributor

@shcherbin shcherbin commented Nov 7, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5782
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR migrates AWS lambda hook to /providers/aws/hooks

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 8, 2019

Codecov Report

Merging #6518 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6518      +/-   ##
==========================================
- Coverage   84.08%   83.77%   -0.31%     
==========================================
  Files         635      636       +1     
  Lines       36849    36853       +4     
==========================================
- Hits        30983    30873     -110     
- Misses       5866     5980     +114
Impacted Files Coverage Δ
airflow/providers/amazon/aws/hooks/s3.py 95.74% <ø> (ø)
airflow/providers/amazon/aws/hooks/sqs.py 100% <ø> (ø)
airflow/providers/amazon/aws/hooks/athena.py 67.18% <ø> (ø)
...flow/providers/amazon/aws/hooks/lambda_function.py 100% <100%> (ø)
airflow/providers/amazon/aws/sensors/sqs.py 100% <100%> (ø)
...flow/contrib/operators/aws_sqs_publish_operator.py 100% <100%> (ø) ⬆️
airflow/providers/amazon/aws/operators/sqs.py 100% <100%> (ø)
airflow/contrib/sensors/aws_sqs_sensor.py 100% <100%> (ø) ⬆️
airflow/contrib/hooks/aws_lambda_hook.py 100% <100%> (ø) ⬆️
airflow/hooks/S3_hook.py 100% <100%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813cd43...ec24d7c. Read the comment docs.

@ratb3rt
Copy link
Copy Markdown
Contributor

ratb3rt commented Nov 8, 2019

FWIW, there's a possible change in structure coming: providers.amazon.aws instead of providers.aws...
I've done the base work for moving into providers/amazon/aws already in #6502 - doc paths, etc. If that gets merged first (after the vote on AIP-21 v2 is closed), then your update would be easier...

@shcherbin shcherbin changed the title [AIRFLOW-5782] Migrate AWS Lambda to /providers/aws [AIP-21] [AIRFLOW-5782] Migrate AWS Lambda to /providers/amazon/aws [AIP-21] Nov 9, 2019
@shcherbin
Copy link
Copy Markdown
Contributor Author

@ratb3rt, thank you for the heads up. I've updated the code to use the new package path.

@shcherbin
Copy link
Copy Markdown
Contributor Author

Hi @potiuk, I've noticed you were reviewing other related PR, would you mind having a look at this one, please?
There has been a lot of duplicated effort around a simple package migration. The sooner we merge this the better.

@shcherbin shcherbin force-pushed the airflow-5782-migrate-aws-lambda-to-providers branch 2 times, most recently from 8f70875 to eb57806 Compare November 9, 2019 11:57
[AIRFLOW-5782] Fix broken imports.

[AIRFLOW-5782] Refresh updating.md

[AIRFLOW-5782] Restore temporary pending-deprecation imports.

[AIRFLOW-5782] Update sphinx excluded files.

[AIRFLOW-5782] Fix broken mock patches.
@shcherbin shcherbin force-pushed the airflow-5782-migrate-aws-lambda-to-providers branch from 9a92f78 to ec24d7c Compare November 9, 2019 13:29
@potiuk potiuk merged commit 3d76fb4 into apache:master Nov 9, 2019
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Nov 9, 2019

Thanks! Merged.

@shcherbin
Copy link
Copy Markdown
Contributor Author

You are very welcome!

@shcherbin shcherbin deleted the airflow-5782-migrate-aws-lambda-to-providers branch November 9, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants