UI: Fix mapped task XCom navigation from Grid #64875#65192
Open
vishakha1411 wants to merge 2 commits intoapache:mainfrom
Open
UI: Fix mapped task XCom navigation from Grid #64875#65192vishakha1411 wants to merge 2 commits intoapache:mainfrom
vishakha1411 wants to merge 2 commits intoapache:mainfrom
Conversation
bbovenzi
reviewed
Apr 14, 2026
Contributor
bbovenzi
left a comment
There was a problem hiding this comment.
Looks good. Let's add a quick regression test in this PR.
Contributor
Author
|
I have added a test case in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64875
What changed
This fixes UI navigation when switching between dynamically mapped tasks from Grid while viewing a task-instance tab such as XCom.
Previously, navigating from a mapped task instance page like:
/tasks/task_1/mapped/0/xcomto another mapped task from Grid could preserve the
xcomsub-route even when no concrete mapped index was selected for the destination task. That could produce an invalid route and result inmap_index=NaN.Result
Instead of failing with an invalid
map_index, navigation now lands on:/tasks/<task_id>/mappedi.ewhich lets the user choose a mapped task instance before opening XCom or other task-instance tabs.
I have not added a regression test in this PR yet. If maintainers prefer, I can add one in a follow-up or update this PR.