Skip to content

UI: Fix mapped task XCom navigation from Grid #64875#65192

Open
vishakha1411 wants to merge 2 commits intoapache:mainfrom
vishakha1411:fix_xcom_mapping
Open

UI: Fix mapped task XCom navigation from Grid #64875#65192
vishakha1411 wants to merge 2 commits intoapache:mainfrom
vishakha1411:fix_xcom_mapping

Conversation

@vishakha1411
Copy link
Copy Markdown
Contributor

Fixes #64875

What changed

This fixes UI navigation when switching between dynamically mapped tasks from Grid while viewing a task-instance tab such as XCom.

Previously, navigating from a mapped task instance page like:

/tasks/task_1/mapped/0/xcom

to another mapped task from Grid could preserve the xcom sub-route even when no concrete mapped index was selected for the destination task. That could produce an invalid route and result in map_index=NaN.

Result

Instead of failing with an invalid map_index, navigation now lands on:

/tasks/<task_id>/mapped i.e
image

which lets the user choose a mapped task instance before opening XCom or other task-instance tabs.

I have not added a regression test in this PR yet. If maintainers prefer, I can add one in a follow-up or update this PR.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's add a quick regression test in this PR.

@vishakha1411
Copy link
Copy Markdown
Contributor Author

I have added a test case in links.test.ts for this navigation path to check that switching to another mapped task without a selected map index goes to the mapped task overview. This makes sure we don’t preserve the invalid xcom sub-route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI - navigation between DTM xcom fail

2 participants