[v3-2-test] Prevent Session leak from StreamingResponse API endpoints#65193
Merged
vatsrahul1001 merged 1 commit intov3-2-testfrom Apr 14, 2026
Merged
[v3-2-test] Prevent Session leak from StreamingResponse API endpoints#65193vatsrahul1001 merged 1 commit intov3-2-testfrom
vatsrahul1001 merged 1 commit intov3-2-testfrom
Conversation
The comment in the test sums up what was going on, but essentially this result in `session.close` being called when the endpoint returned, but before the response was generated. Then SQLA was 'helpful' and re-opened it. However since the teardown/post-yield code has already run, this new session is never closed. This results in a connection open that leaks untli Python's full GC runs (i.e. `gc.collect()`) -- it going out of scope doesn't delete things as the Session and the RootTransaction form a cycle. (cherry picked from commit 5559365)
vatsrahul1001
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
potiuk,
shahar1 and
vincbeck
as code owners
boring-cyborg
bot
added
area:dev-tools
area:production-image
boring-cyborg
bot
added
the
backport-to-v3-2-test
vatsrahul1001
requested review from
Fokko,
Lee-W,
RNHTTR,
bbovenzi,
dheerajturaga,
guan404ming,
hussein-awala,
josh-fell,
o-nikolas,
pierrejeambrun and
uranusjr
as code owners
vatsrahul1001
requested review from
XD-DENG,
bolkedebruin,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
vatsrahul1001
removed
the
backport-to-v3-2-test
vatsrahul1001
added
area:API
pierrejeambrun
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #65162
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.