Skip to content

fix: replace bare except with Exception in pytest_plugin.py#65199

Open
harshadkhetpal wants to merge 4 commits intoapache:mainfrom
harshadkhetpal:fix/bare-except-pytest-plugin
Open

fix: replace bare except with Exception in pytest_plugin.py#65199
harshadkhetpal wants to merge 4 commits intoapache:mainfrom
harshadkhetpal:fix/bare-except-pytest-plugin

Conversation

@harshadkhetpal
Copy link
Copy Markdown

Summary

Replaces a bare except: clause with except Exception: in devel-common/src/tests_common/pytest_plugin.py.

Motivation

Bare except: clauses catch BaseException, which includes KeyboardInterrupt and SystemExit. This can mask critical signals like Ctrl-C. PEP 8 flags this as E722.

Change

# Before
try:
    ...
except:
    ...

# After
try:
    ...
except Exception:
    ...

Testing

No behavior change in normal error paths — only KeyboardInterrupt/SystemExit now propagate as expected.

Bare except clauses catch BaseException, including KeyboardInterrupt
and SystemExit. Using the more specific `except Exception:` avoids
swallowing system-level exceptions (PEP 8 E722).
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Apr 14, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant