Fix ArgNotSet repr to use stable string instead of memory address#65222
Open
necmo wants to merge 2 commits intoapache:mainfrom
Open
Fix ArgNotSet repr to use stable string instead of memory address#65222necmo wants to merge 2 commits intoapache:mainfrom
necmo wants to merge 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
kaxil
reviewed
Apr 15, 2026
Replace __repr__ and __str__ overrides with a serialize() method. This avoids inheritance issues with SetDuringExecution and targets the actual serialization path in serialize_template_field(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: closes #65220
Summary
Add
__repr__and__str__methods toArgNotSetto return a stable"NOTSET"string instead of Python's default<... object at 0x...>which includes the memory address.Problem
When
ArgNotSetinstances leak into serialization paths that fall through tostr()/repr()(e.g.,TriggerDagRunOperator'slogical_dateparameter appearing in serializeddefault_args), the output includes the memory address:Since the scheduler runs
DagFileProcessoras separate subprocesses, each process allocatesArgNotSetat a different address → different serialized JSON → newdag_versionon every parse cycle (~30 seconds).Fix
This ensures that even if
ArgNotSetbypasses the properis_arg_set()check in serialization, the resulting string is deterministic and does not cause spurious DAG version increments.