fix(amazon): correct AWS China SQS regex to use amazonaws.com.cn#65299
Merged
vincbeck merged 1 commit intoapache:mainfrom Apr 15, 2026
Merged
fix(amazon): correct AWS China SQS regex to use amazonaws.com.cn#65299vincbeck merged 1 commit intoapache:mainfrom
vincbeck merged 1 commit intoapache:mainfrom
Conversation
Follow-up to apache#65173. AWS China regions use the endpoint suffix amazonaws.com.cn, not amazonaws.cn. The regex shipped in apache#65173 fails to match real AWS China SQS URLs like: https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my-sqs Update the regex to accept the optional .cn suffix on amazonaws.com, and update the tests to use the correct endpoint. Reported by @crazy-canux in apache#65128.
boring-cyborg
Bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Apr 15, 2026
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Apr 16, 2026
…che#65299) Follow-up to apache#65173. AWS China regions use the endpoint suffix amazonaws.com.cn, not amazonaws.cn. The regex shipped in apache#65173 fails to match real AWS China SQS URLs like: https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my-sqs Update the regex to accept the optional .cn suffix on amazonaws.com, and update the tests to use the correct endpoint. Reported by @crazy-canux in apache#65128.
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65173. As reported by @crazy-canux, AWS China regions use the endpoint suffix `amazonaws.com.cn`, not `amazonaws.cn`. The regex shipped in #65173 fails to match real AWS China SQS URLs like:
```
https://sqs.cn-northwest-1.amazonaws.com.cn/123456/my-sqs
```
This PR updates the regex to accept the optional `.cn` suffix on `amazonaws.com`, and updates the tests to use the correct endpoint.
Reopens / properly fixes #65128.