Skip to content

Widen BaseExecutor method signatures to accept WorkloadKey#65392

Merged
ferruzzi merged 6 commits intoapache:mainfrom
anishgirianish:widen-base-executor-to-workload-key
Apr 17, 2026
Merged

Widen BaseExecutor method signatures to accept WorkloadKey#65392
ferruzzi merged 6 commits intoapache:mainfrom
anishgirianish:widen-base-executor-to-workload-key

Conversation

@anishgirianish
Copy link
Copy Markdown
Contributor

@anishgirianish anishgirianish commented Apr 16, 2026


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Summary

Widens BaseExecutor method signatures from TaskInstanceKey to WorkloadKey (union of TaskInstanceKey | CallbackKey) so executors can signal state transitions for both task and callback workloads.

Unblocks follow-up work on callback-aware executors.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:Executors-core LocalExecutor & SequentialExecutor label Apr 16, 2026
@anishgirianish anishgirianish force-pushed the widen-base-executor-to-workload-key branch from c1cefaa to 2c28fc2 Compare April 16, 2026 22:08
@anishgirianish anishgirianish changed the title Widen BaseExecutor signatures to accept WorkloadKey Widen BaseExecutor method signatures to accept WorkloadKey Apr 16, 2026
Comment thread airflow-core/src/airflow/executors/base_executor.py Outdated
@anishgirianish anishgirianish requested a review from ferruzzi April 17, 2026 01:33
Copy link
Copy Markdown
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround. This should unblock #62887

Comment thread airflow-core/src/airflow/executors/base_executor.py Outdated
@anishgirianish anishgirianish force-pushed the widen-base-executor-to-workload-key branch from 8ec4a8b to e61ea2d Compare April 17, 2026 19:42
@ferruzzi ferruzzi merged commit 832a74f into apache:main Apr 17, 2026
140 checks passed
shivaam added a commit to shivaam/airflow that referenced this pull request Apr 19, 2026
Enables the ECS executor to dispatch ExecuteCallback workloads (deadline
alerts) alongside regular ExecuteTask workloads. Builds on apache#65392 which
widened BaseExecutor signatures to accept WorkloadKey.

- supports_callbacks = True (gated on AIRFLOW_V_3_3_PLUS)
- Widen key types to WorkloadKey throughout EcsQueuedTask / EcsTaskCollection
- Branch _process_workloads on ExecuteTask vs ExecuteCallback
- Add AIRFLOW_V_3_3_PLUS to version_compat.py
- Unit tests for queueing, processing, serialization, sync, mixed keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Executors-core LocalExecutor & SequentialExecutor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants