Skip to content

fix: prevent webhook_endpoint extra field from being sent as HTTP header in DiscordWebhookHook#65398

Open
charmikadi wants to merge 2 commits intoapache:mainfrom
charmikadi:fix/discord-webhook-extra-header-injection
Open

fix: prevent webhook_endpoint extra field from being sent as HTTP header in DiscordWebhookHook#65398
charmikadi wants to merge 2 commits intoapache:mainfrom
charmikadi:fix/discord-webhook-extra-header-injection

Conversation

@charmikadi
Copy link
Copy Markdown

When using DiscordWebhookHook with a connection that stores webhook_endpoint in the extra field, Airflow 3.2 now injects remaining connection extra fields as HTTP request headers via HttpHook.get_conn(). This causes Discord to
reject the request with 400 Bad Request because webhook_endpoint is not a valid HTTP header.

The fix overrides get_conn in DiscordWebhookHook to remove webhook_endpoint from the connection's extra fields before HttpHook processes them. Since webhook_endpoint is used to build the request URL, not as an HTTP header,
it should never be sent to Discord. The original extra is restored in a finally block to avoid any side effects.

Closes #65279


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Apr 17, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Override get_conn to prevent webhook_endpoint from being sent as an HTTP header.
Fixed issue with DiscordWebhookHook sending webhook_endpoint as an HTTP header, resulting in 400 Bad Request errors after Airflow 3.2 update.
@charmikadi charmikadi force-pushed the fix/discord-webhook-extra-header-injection branch from 571df59 to e91c1ed Compare April 17, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DiscordNotifier return bad request when using Airflow 3.2.0

1 participant