Add multi team secret support to VaultBackend#65493
Merged
shahar1 merged 1 commit intoapache:mainfrom Apr 22, 2026
Merged
Conversation
13e0f1a to
4c3c7e0
Compare
baraka-akeyless
added a commit
to baraka-akeyless/airflow
that referenced
this pull request
Apr 20, 2026
When core.multi_team is enabled, the secrets backend now looks up
secrets under {base_path}/{team_name}/{key} first, falling back to
a global path. Supports use_team_secrets_path and global_secrets_path
configuration options, matching the VaultBackend pattern from apache#65493.
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds multi-team (team-scoped) secret lookup behavior to the HashiCorp VaultBackend, allowing connection/variable resolution to prefer {base_path}/{team_name}/{key} and fall back to a global path when configured.
Changes:
- Add team/global lookup logic to
VaultBackend(including newuse_team_secrets_pathandglobal_secrets_pathkwargs). - Update
get_connection()andget_variable()to use team-aware secret resolution when multi-team mode is enabled. - Add unit tests covering team-scoped and global-fallback secret retrieval.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
providers/hashicorp/src/airflow/providers/hashicorp/secrets/vault.py |
Implements multi-team path resolution and global fallback behavior in VaultBackend. |
providers/hashicorp/tests/unit/hashicorp/secrets/test_vault.py |
Adds tests validating team-scoped lookup, disabling team separation, and global fallback behavior. |
4c3c7e0 to
061808c
Compare
vincbeck
reviewed
Apr 21, 2026
vincbeck
reviewed
Apr 21, 2026
061808c to
a78ad65
Compare
vincbeck
reviewed
Apr 21, 2026
a78ad65 to
e4cb164
Compare
vincbeck
approved these changes
Apr 21, 2026
e4cb164 to
32be5da
Compare
eladkal
pushed a commit
to baraka-akeyless/airflow
that referenced
this pull request
Apr 21, 2026
When core.multi_team is enabled, the secrets backend now looks up
secrets under {base_path}/{team_name}/{key} first, falling back to
a global path. Supports use_team_secrets_path and global_secrets_path
configuration options, matching the VaultBackend pattern from apache#65493.
Made-with: Cursor
7 tasks
Contributor
|
Tests are failing |
cc6ba4a to
17c0ecd
Compare
17c0ecd to
61e6931
Compare
eladkal
approved these changes
Apr 22, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
eladkal
pushed a commit
to baraka-akeyless/airflow
that referenced
this pull request
Apr 22, 2026
When core.multi_team is enabled, the secrets backend now looks up
secrets under {base_path}/{team_name}/{key} first, falling back to
a global path. Supports use_team_secrets_path and global_secrets_path
configuration options, matching the VaultBackend pattern from apache#65493.
Made-with: Cursor
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for team scoped secrets to the VaultBackend secrets backend
related: #65372
If multi_team is enabled, the VaultBackend will now prefix each variable or connection id with the team name,
i.e.
{base_path}/{team_name}/{key}.If no key is found under the team specific secrets then a global path will be searched instead. This global path
will default to using the base path, but can also be prefixed e.g.
{base_path}/global/{key}or{base_path}/shared/{key}etc.Was generative AI tooling used to co-author this PR?