Skip to content

Fix e2e flaky in AssetDetailPage and ConnectionsPage tests#65494

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix-flaky-parts
Apr 22, 2026
Merged

Fix e2e flaky in AssetDetailPage and ConnectionsPage tests#65494
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix-flaky-parts

Conversation

@choo121600
Copy link
Copy Markdown
Member

@choo121600 choo121600 commented Apr 19, 2026

Summary

Re-enables two e2e tests that were previously marked as test.fixme in #65487 by stabilizing them using Playwright-native synchronization. No UI changes.

Problem

In CI (Linux WebKit), Ark UI dialog/popover occasionally leaves residual state longer than expected, which can block subsequent clicks.
This is due to lingering UI artifacts (e.g. backdrop pointer-events, stat-card layout) exceeding the default 10s action timeout.

The issue is specific to the resource-constrained CI runner (2 parallel workers) and is not reproducible on macOS Safari.

Changes

  • ConnectionsPage
    • Replaced UI-based completion checks (URL change, toast, dialog closed) with waitForResponse on /api/v2/connections
    • Increased delete button click timeout to 30s to handle CI slowness.
  • AssetDetailPage
    • Added waitForResponse for the asset detail API to ensure all data is loaded before proceeding.
    • Added toBeEnabled() pre-check
    • Replaced with standard click() for proper actionability

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 19, 2026
@choo121600 choo121600 marked this pull request as draft April 20, 2026 06:23
@choo121600 choo121600 force-pushed the fix-flaky-parts branch 3 times, most recently from 1356ce8 to 883b3a6 Compare April 20, 2026 09:59
@choo121600 choo121600 marked this pull request as ready for review April 20, 2026 11:15
@choo121600
Copy link
Copy Markdown
Member Author

This doesn’t seem to be fully working yet. I’ll check further.

@choo121600 choo121600 marked this pull request as draft April 21, 2026 08:27
@choo121600 choo121600 marked this pull request as ready for review April 21, 2026 15:22
@choo121600
Copy link
Copy Markdown
Member Author

Thanks :)

@choo121600 choo121600 merged commit c588c66 into apache:main Apr 22, 2026
154 checks passed
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 22, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Cloud-Architect-Emma pushed a commit to Cloud-Architect-Emma/airflow that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants