Skip to content

[AIRFLOW-5900] avoid unnecessary system calls in heartbeat_callback#6551

Merged
potiuk merged 1 commit intoapache:masterfrom
houqp:local_task_job
Nov 12, 2019
Merged

[AIRFLOW-5900] avoid unnecessary system calls in heartbeat_callback#6551
potiuk merged 1 commit intoapache:masterfrom
houqp:local_task_job

Conversation

@houqp
Copy link
Member

@houqp houqp commented Nov 12, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Optimize hearbeat callback, avoid system calls when they are not needed.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Existing tests already covered the change.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

Codecov Report

Merging #6551 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6551      +/-   ##
==========================================
- Coverage   84.07%   83.78%   -0.29%     
==========================================
  Files         639      639              
  Lines       36900    36900              
==========================================
- Hits        31024    30917     -107     
- Misses       5876     5983     +107
Impacted Files Coverage Δ
airflow/jobs/local_task_job.py 90% <100%> (+5%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25ef2b...064d1fc. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and small optimisation :).

@potiuk potiuk merged commit 6b8dc40 into apache:master Nov 12, 2019
GnunuX pushed a commit to GnunuX/airflow that referenced this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants