[AIRFLOW-5900] avoid unnecessary system calls in heartbeat_callback#6551
Merged
potiuk merged 1 commit intoapache:masterfrom Nov 12, 2019
Merged
[AIRFLOW-5900] avoid unnecessary system calls in heartbeat_callback#6551potiuk merged 1 commit intoapache:masterfrom
potiuk merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6551 +/- ##
==========================================
- Coverage 84.07% 83.78% -0.29%
==========================================
Files 639 639
Lines 36900 36900
==========================================
- Hits 31024 30917 -107
- Misses 5876 5983 +107
Continue to review full report at Codecov.
|
potiuk
approved these changes
Nov 12, 2019
Member
potiuk
left a comment
There was a problem hiding this comment.
Nice and small optimisation :).
GnunuX
pushed a commit
to GnunuX/airflow
that referenced
this pull request
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Optimize hearbeat callback, avoid system calls when they are not needed.
Tests
Existing tests already covered the change.
Commits
Documentation