Skip to content

render cleanup RBAC only for KubernetesExecutor#65539

Merged
jscheffl merged 1 commit intoapache:mainfrom
henry3260:fix-rbac-kubernetesexecutor-guard
Apr 20, 2026
Merged

render cleanup RBAC only for KubernetesExecutor#65539
jscheffl merged 1 commit intoapache:mainfrom
henry3260:fix-rbac-kubernetesexecutor-guard

Conversation

@henry3260
Copy link
Copy Markdown
Contributor

Why

cleanup Role and RoleBinding were rendered whenever cleanup.enabled was true, even when cleanup CronJob and cleanup ServiceAccount were not rendered.
This created inconsistent chart output and unnecessary RBAC resources in non-KubernetesExecutor setups.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@bugraoz93 bugraoz93 added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label Apr 20, 2026
@jscheffl jscheffl merged commit f99b7c0 into apache:main Apr 20, 2026
105 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

jscheffl pushed a commit that referenced this pull request Apr 20, 2026
…65539) (#65562)

(cherry picked from commit f99b7c0)

Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants