Skip to content

Fix Graph unit tests conflicting with global mock#65546

Closed
yuseok89 wants to merge 1 commit into
apache:mainfrom
yuseok89:fix/ui-graph-test-global-mock
Closed

Fix Graph unit tests conflicting with global mock#65546
yuseok89 wants to merge 1 commit into
apache:mainfrom
yuseok89:fix/ui-graph-test-global-mock

Conversation

@yuseok89
Copy link
Copy Markdown
Contributor

@yuseok89 yuseok89 commented Apr 20, 2026

CI is currently broken on main due to failures in Graph.test.tsx, which blocks all in-flight PRs. This is a minimal fix to unblock CI: useGridTiSummariesStream is never invoked because the global Graph mock in testsSetup.ts replaces the real component, so this change calls vi.unmock in that single test file.

If we would prefer to avoid vi.unmock here, possible directions include extracting the tested logic into a hook or narrowing the scope of the global Graph mock in testsSetup.ts.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    • Cursor

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 20, 2026
@yuseok89 yuseok89 force-pushed the fix/ui-graph-test-global-mock branch from c8e8bcd to e30e82d Compare April 20, 2026 15:51
@yuseok89 yuseok89 force-pushed the fix/ui-graph-test-global-mock branch from e30e82d to 8e06c95 Compare April 20, 2026 15:52
@yuseok89
Copy link
Copy Markdown
Contributor Author

Duplicate of #65555

@yuseok89 yuseok89 closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant