Add Snowflake data quality operator examples to provider docs and system tests#65623
Add Snowflake data quality operator examples to provider docs and system tests#65623PrithviBadiga wants to merge 3 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
SameerMesiah97
left a comment
There was a problem hiding this comment.
CI needs to be triggered but this looks fine to me. I have left a few comments.
|
Thanks for the review. I pushed an update that:
Please take another look. |
|
@SameerMesiah97 @potiuk Thanks for the review. The latest fix is pushed and the remaining checks appear to be awaiting maintainer approval for this fork PR. When you have a chance, could you approve/run them? |
|
@PrithviBadiga This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
|
Just to coment on that - please resolve the comments if you think they are resolved and undraft it |
|
I did it for you now so next time just resolve comments |
|
Quick follow-up to the triage comment above — one clarification on the "Unresolved review comments" item: Once you believe a thread has been addressed — whether by pushing a fix, or by replying in-thread with an explanation of why the suggestion doesn't apply — please mark the thread as resolved yourself by clicking the "Resolve conversation" button at the bottom of each thread. Reviewers don't auto-close their own threads, so an addressed-but-unresolved thread reads as "still waiting on the author" and keeps the PR from moving forward. The author doing the resolve-click is the expected convention on this project. |
|
@potiuk Thanks for handling that and for the clarification. I’ll make sure to resolve the review threads myself next time after addressing them. Also, all checks are passing now. When you have a chance, could you merge this PR? |
I just had a look at it again and it looks fine to me. I have approved it but I cannot merge PRs. |
Adds Snowflake provider examples for:
SnowflakeCheckOperatorSnowflakeValueCheckOperatorSnowflakeIntervalCheckOperatorUpdates:
providers/snowflake/tests/system/snowflake/example_snowflake.pydsandvalueproviders/snowflake/docs/operators/snowflake.rstValidate datasectionexampleincludeVerification:
python3 -m py_compile providers/snowflake/tests/system/snowflake/example_snowflake.pyThis closes: #65098
Was generative AI tooling used to co-author this PR?