Skip to content

Fix SQS CreateQueue type error by casting attributes to string#65649

Merged
shahar1 merged 2 commits intoapache:mainfrom
mscsy0104:fix/65592-sqs-visibility-timeout
Apr 22, 2026
Merged

Fix SQS CreateQueue type error by casting attributes to string#65649
shahar1 merged 2 commits intoapache:mainfrom
mscsy0104:fix/65592-sqs-visibility-timeout

Conversation

@mscsy0104
Copy link
Copy Markdown
Contributor

@mscsy0104 mscsy0104 commented Apr 22, 2026

When creating an SQS queue, AWS requires all attribute values to be strings. Currently, if a user passes an integer (e.g., VisibilityTimeout=30), it causes a botocore.exceptions.ParamValidationError or InvalidAttributeValue error in real AWS environments.

This PR ensures all attribute values are cast to strings before being passed to the boto3 client.

Related Issue:
closes: #65592

Tests performed:
Verified with a reproduction script in Breeze (Python 3.13) that integer values no longer trigger validation errors.

스크린샷 2026-04-22 오후 5 55 45
Was generative AI tooling used to co-author this PR?
  • Yes (Gemini)

Generated-by: Gemini following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@mscsy0104 mscsy0104 requested a review from o-nikolas as a code owner April 22, 2026 04:27
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 22, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vincbeck
Copy link
Copy Markdown
Contributor

Static checks are failing

@shahar1 shahar1 force-pushed the fix/65592-sqs-visibility-timeout branch from 9a30dc4 to cc56b5a Compare April 22, 2026 15:08
@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented Apr 22, 2026

Rebasing, hopefully it should be ok now

@shahar1 shahar1 merged commit ba3da41 into apache:main Apr 22, 2026
93 checks passed
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 22, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@mscsy0104
Copy link
Copy Markdown
Contributor Author

Rebasing, hopefully it should be ok now

Thanks for the hand! I was just working on fixing those static check failures locally. Appreciate the support and for getting this across the finish line!

@mscsy0104 mscsy0104 deleted the fix/65592-sqs-visibility-timeout branch April 23, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid value for the parameter VisibilityTimeout as worker try to create queue with name *-reply-celery-pidbox in SQS

3 participants