Add apache-airflow-mypy to devel-common mypy dependency group#65660
Closed
shahar1 wants to merge 1 commit intoapache:mainfrom
Closed
Add apache-airflow-mypy to devel-common mypy dependency group#65660shahar1 wants to merge 1 commit intoapache:mainfrom
shahar1 wants to merge 1 commit intoapache:mainfrom
Conversation
PR apache#61422 (merged Apr 22, 2026) changed the root pyproject.toml mypy plugin references from file-path form to module form: plugins = [ "airflow_mypy.plugins.decorators", "airflow_mypy.plugins.outputs", ] Module-form plugins require the package to be importable in the mypy venv. The mypy hooks for airflow-core, task-sdk, and all other non-provider, non-scripts distributions build their venv by running: uv sync --frozen --project devel-common --group mypy But devel-common's mypy dependency group did not include apache-airflow-mypy (which lives in dev/mypy/). As a result, all those mypy hooks failed with: Error importing plugin "airflow_mypy.plugins.decorators": No module named 'airflow_mypy' Fix: add apache-airflow-mypy to the mypy optional-extra in devel-common/pyproject.toml so it is installed into every affected mypy hook venv.
shahar1
requested review from
eladkal,
hussein-awala,
jscheffl,
potiuk and
vincbeck
potiuk
approved these changes
Apr 22, 2026
hussein-awala
approved these changes
Apr 22, 2026
pierrejeambrun
approved these changes
Apr 22, 2026
Contributor
Author
|
Implemented in #65668 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #61422 (merged Apr 22, 2026) changed the root
pyproject.tomlmypy plugin references from file-path form to module form:Module-form plugins require the package to be importable in the mypy venv. The mypy hooks for
airflow-core,task-sdk, and all other non-provider, non-scripts distributions build their venv by running:But
devel-common'smypydependency group did not includeapache-airflow-mypy(which lives indev/mypy/). As a result, all those mypy hooks fail immediately with:This was discovered during the provider release process (#65614) when rebasing onto today's
mainafter #61422 landed.Fix: add
apache-airflow-mypyto themypyoptional-extra indevel-common/pyproject.tomlso it is installed into every affected mypy hook venv.Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot (Claude Sonnet 4.6) following the guidelines