Skip to content

fix(task-sdk): respect default parameter in xcom_pull when map_indexes is not set#65673

Open
armorbreak001 wants to merge 1 commit intoapache:mainfrom
armorbreak001:fix/xcom-pull-default-param
Open

fix(task-sdk): respect default parameter in xcom_pull when map_indexes is not set#65673
armorbreak001 wants to merge 1 commit intoapache:mainfrom
armorbreak001:fix/xcom-pull-default-param

Conversation

@armorbreak001
Copy link
Copy Markdown

Summary

In RuntimeTaskInstance.xcom_pull(), when map_indexes is not specified (the default NOTSET path), the code always appends None to the result list when no XCom is found, ignoring the caller-provided default parameter.

The explicit map_indexes branch (below) correctly uses default. This fix aligns the non-map_indexes path with that behavior.

Before: ti.xcom_pull(task_ids="t", key="k", default="fallback") returns None when no XCom exists.
After: Returns "fallback" as expected per the docstring.

Fixes #64295

…s is not set

When map_indexes is not explicitly set (NOTSET path), xcom_pull
hardcoded None instead of using the caller-provided default value.
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 22, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk added ready for maintainer review Set after triaging when all criteria pass. and removed ready for maintainer review Set after triaging when all criteria pass. labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xcom_pull() ignores default parameter when map_indexes is not set

2 participants