Fix GenAIGenerativeModelHook ignoring Airflow connection credentials#65731
Merged
shahar1 merged 1 commit intoapache:mainfrom Apr 24, 2026
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
get_genai_client() was constructing genai.Client without credentials, causing it to fall back to Application Default Credentials (ADC) even when gcp_conn_id pointed to an explicit service-account connection. Users in environments without ADC (e.g. Docker without workload identity) received DefaultCredentialsError at runtime. Pass self.get_credentials() to genai.Client so the hook honours the configured Airflow connection, consistent with every other Google provider hook (GCS, BigQuery, etc.). Fixes: apache#65709
71df93a to
ee67d41
Compare
Contributor
Author
|
@shahar1 please approve again, I pushed an empty rebase to rerun a failing provider test |
Contributor
Author
shahar1
approved these changes
Apr 24, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Contributor
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GenAIGenerativeModelHook.get_genai_client()constructs agenai.Clientwithout passing credentials, causing it to fall back to Application Default Credentials (ADC) even whengcp_conn_idis set to an explicit service-account connection. Users in environments without ADC (e.g. Docker containers, on-premise) receiveDefaultCredentialsErrorat runtime.The fix passes
self.get_credentials()togenai.Client, which is the same pattern used by every other Google provider hook (GCS, BigQuery, Vertex AI, etc.).Fixes #65709
Changes
providers/google/src/airflow/providers/google/cloud/hooks/gen_ai.py: Passcredentials=self.get_credentials()togenai.ClientinGenAIGenerativeModelHook.get_genai_client().providers/google/tests/unit/google/cloud/hooks/test_gen_ai.py: Addtest_get_genai_client_passes_connection_credentialsto assert credentials from the connection are forwarded to the client.Root Cause
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.