Skip to content

Add is_docker_available helper for silent Docker checks#65732

Draft
TALBIYA-PARVEEN wants to merge 1 commit into
apache:mainfrom
TALBIYA-PARVEEN:fix/docker-availability-clean-v2
Draft

Add is_docker_available helper for silent Docker checks#65732
TALBIYA-PARVEEN wants to merge 1 commit into
apache:mainfrom
TALBIYA-PARVEEN:fix/docker-availability-clean-v2

Conversation

@TALBIYA-PARVEEN
Copy link
Copy Markdown

@TALBIYA-PARVEEN TALBIYA-PARVEEN commented Apr 23, 2026

What does this PR do?

Adds is_docker_available() to dev/breeze/src/airflow_breeze/utils/docker_command_utils.py.

The existing check_docker_is_running() prints console output and calls sys.exit(1) on failure, making it unsuitable as a silent boolean guard.

The new helper returns True/False without side effects, following the same pattern as is_docker_rootless().

Handles three cases:

  • Docker running → True
  • Docker installed but not running → False
  • Docker not installed → False (via FileNotFoundError)

Was generative AI tooling used to co-author this PR?

  • [yes ] Yes

Checklist

  • No newsfragment needed (internal Breeze utility, not user-facing)
  • No docs update needed

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 27, 2026

Why do you need it?

@potiuk potiuk marked this pull request as draft May 18, 2026 01:40
@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 18, 2026

@TALBIYA-PARVEEN This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Pre-commit / static checks: CI image checks / Static checks is failing. Run prek run --from-ref main --stage pre-commit locally and fix anything that flags. See the static-checks docs.
  • Provider-distribution compat tests: Compat 2.11.1:P3.10, Compat 3.0.6:P3.10, Compat 3.1.8:P3.10, and Compat 3.2.1:P3.10 are failing. Typically means the change uses a symbol or API not present in older Airflow core versions; check airflow>=... lower bounds and conditional imports in the affected provider(s). See the provider distributions docs.

What to do next:

  • Make static checks pass locally: prek run --from-ref main --stage pre-commit.
  • Resolve the compat failures by guarding new APIs with version-aware imports or by adjusting the provider's airflow>=… lower bound if the change really requires the newer core.
  • Mark the PR as "Ready for review" when you're done.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants