Fix FAB password hashing to respect FAB_PASSWORD_HASH_METHOD config#65735
Merged
vincbeck merged 1 commit intoapache:mainfrom Apr 27, 2026
Merged
Conversation
a3c2bb4 to
9bbe0c2
Compare
vincbeck
approved these changes
Apr 23, 2026
Contributor
|
CI is failing |
e7adb2d to
e78a7ad
Compare
e78a7ad to
594130d
Compare
Contributor
Author
|
@vincbeck please merge the PR. Thank you. |
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FabAirflowSecurityManagerOverridecontains three baregenerate_password_hash(password)calls inreset_password,add_user, andadd_register_userthat ignore theFAB_PASSWORD_HASH_METHODkey in the Flask app config. On FIPS-compliant systems, operators set this config to an approved algorithm (e.g.pbkdf2:sha256) but the hardcoded calls bypass it, causing authentication failures.The fix introduces a
_hash_password()helper that readsFAB_PASSWORD_HASH_METHODfromcurrent_app.config(defaulting toscrypt) and replaces all three call sites.Fixes #65728
Changes
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py: Add_hash_password(password)helper; replace 3 baregenerate_password_hash(password)calls inreset_password,add_user, andadd_register_user.providers/fab/tests/unit/fab/auth_manager/test_security.py: Add 4 tests covering helper config-forwarding, scrypt fallback, and both callers.Root Cause
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.