Skip to content

Fix cleanup pod lifecycle hooks not being applied#65764

Merged
jscheffl merged 1 commit into
apache:mainfrom
henry3260:add-Lifecycle-in-clean-up
Apr 24, 2026
Merged

Fix cleanup pod lifecycle hooks not being applied#65764
jscheffl merged 1 commit into
apache:mainfrom
henry3260:add-Lifecycle-in-clean-up

Conversation

@henry3260
Copy link
Copy Markdown
Contributor

Why

The chart already exposes cleanup.containerLifecycleHooks in values.yaml, but the cleanup CronJob template never used that value. In practice, this means users can configure the option but it has no effect.

This change fixes that mismatch between chart values and template behavio.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Copy link
Copy Markdown
Contributor

@Miretpl Miretpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label Apr 24, 2026
@jscheffl jscheffl merged commit 294dd5e into apache:main Apr 24, 2026
105 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

jscheffl pushed a commit that referenced this pull request Apr 24, 2026
…65764) (#65822)

(cherry picked from commit 294dd5e)

Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 24, 2026
…pache#65764)

(cherry picked from commit 294dd5e)

Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260 henry3260 deleted the add-Lifecycle-in-clean-up branch April 24, 2026 22:22
@jscheffl jscheffl added this to the Airflow Helm Chart 1.22.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants