select unassigned asset triggers from db

[renat-sagut]

Fixes a bug where multiple triggerer replicas could pick up the same asset trigger from db. The query now selects only unassigned triggers, similar to task instance triggers.

• related: Triggerer stalling after a while #65286
• related: fix frame mismatch in triggerer #65622

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[jscheffl]

Sounds reasonable for me - with current code ALL triggeres pick up the task in parallel? As I am not an expert would need another pair of eyes for review.

Would request an expert review from @uranusjr or @dabla maybe if not @ashb.

[dabla]

Sounds reasonable for me - with current code ALL triggeres pick up the task in parallel? As I am not an expert would need another pair of eyes for review.

Would request an expert review from @uranusjr or @dabla maybe if not @ashb.

I think @ashb or @uranusjr are the biggest experts on that field. Looks good to me but a proof of logging that it works would maybe be an option. Also dunno how SQLAlchemy queries are being unit tested at all. Would be good if we would have a unit test that guards this specific code from regression if future changes would occur. WDYT @jscheffl ?

[jscheffl]

Would be good if we would have a unit test that guards this specific code from regression if future changes would occur. WDYT @jscheffl ?

Would be good having a unit test but testing the query for elements is a bit self-fulfuilling. Not sure how a "good test" would look like. I have only bad tests in mind which do not help. But I see there are explicit 4 tests. @renat-sagut can you add a test for this (Or extend one of the existing tests for this)?

[ashb]

Agreed, generally the important thing is to test the behaviour of the query, not the exact query produced

[ashb]

This query uses SELECT ... FOR UPDATE SKIP LOCKED so only one Triggerer will get each row.

What about unit tests?

[renat-sagut]

Would be good if we would have a unit test that guards this specific code from regression if future changes would occur. WDYT @jscheffl ?

Would be good having a unit test but testing the query for elements is a bit self-fulfuilling. Not sure how a "good test" would look like. I have only bad tests in mind which do not help. But I see there are explicit 4 tests. @renat-sagut can you add a test for this (Or extend one of the existing tests for this)?

added tests

[jscheffl]

Good for me! Would like to have a second reviewer looking at it prior merge.

*) Assuming the nit in ruff format is fixed of course...

[potiuk]

LGTM — small, well-targeted fix that brings the asset-trigger query in line with the task-instance-trigger query at line 427 (alive_triggerer_ids filter). Test coverage is solid: unassigned-included, dead-triggerer-included, alive-triggerer-excluded, and ordering+capacity. Following @jscheffl's approval.

(Out of scope for this PR, but worth a quick look as a follow-up: the callback-trigger branch a few lines above doesn't carry the same alive_triggerer_ids filter — if callbacks can race in the same way, that may want the same fix.)

---

This review was drafted by an AI-assisted tool and confirmed by an Apache Airflow maintainer. The maintainer approving this PR has read the findings and signed off. If something feels off, please reply on the PR and a maintainer will follow up.

More on how Apache Airflow handles maintainer review: contributing-docs/05_pull_requests.rst.

---

Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting

[jscheffl]

Marking for backporting to have this in next patch release. As no other feedback... merging now...

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test