Initial overlay example for Keda and Structure pre-commit hook#65897
Initial overlay example for Keda and Structure pre-commit hook#65897bugraoz93 wants to merge 8 commits intoapache:mainfrom
Conversation
|
Looks good to me! That's a nice approach to make the Helm chart more lean 😊 and it seems that tools like Helmfile can also deploy such Kustomizations alongside the Helm chart: https://helmfile.readthedocs.io/en/latest/advanced-features/#deploy-kustomizations-with-helmfile |
Thanks Daniel for the review and feedback! Next step is to add smoke test after this PR so we will have tested overlay. We can start using once status.yaml is in the tested phase with the smoke test PR :) |
Miretpl
left a comment
There was a problem hiding this comment.
Looks really nice, just small comments.
Looks good to me! That's a nice approach to make the Helm chart more lean 😊 and it seems that tools like Helmfile can also deploy such Kustomizations alongside the Helm chart: https://helmfile.readthedocs.io/en/latest/advanced-features/#deploy-kustomizations-with-helmfile
I didn't try this feature out yet, but this would probably even allow deploying everything with a single command. Looking forward to try out this feature!
I didn't check it too, but at the end, if it were possible to deploy Helm + Kustomize with a single command, it would be a very nice addition - worth investigating for sure.
| triggerer, workers). | ||
| * Removing it requires changes to Airflow's own configuration. | ||
| * It has no external owner. | ||
| * It is assumed that the larger majority (>80%) will need and use this function for productive use |
There was a problem hiding this comment.
| * It is assumed that the larger majority (>80%) will need and use this function for productive use | |
| * It is used by the larger majority of users (>80%) for production-ready environments |
Maybe we should also determine it by the possible usage of the feature in terms of where it will be used (prod or non-prod env)? WDYT?
There was a problem hiding this comment.
Everything here can be used in production, right? I am not sure if we should make the environmental difference for them or think about it and give the user which environment to use on which level. How about like this?
| * It is assumed that the larger majority (>80%) will need and use this function for productive use | |
| * It is used by the larger majority of users (>80%) who will need and use this function for productive use |
There was a problem hiding this comment.
Looks good. I had in mind the case of the current postgresql, which was meant only for development, but as it was available for users, they just used it. I fully agree that there should not be a distinction between environments, and if something is added, we assume that it can be used for dev or prod environments.
There was a problem hiding this comment.
Ah you were more nit-picky on the wording that I prepared the proposal :-D Yes of course can and should be used in dev/test as well as production! I wanted to express rather: 80% need it. (then if they need it probably in all stages)
So in short it can be:
| * It is assumed that the larger majority (>80%) will need and use this function for productive use | |
| * It is used by the larger majority of users (>80%) |
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
Miretpl
left a comment
There was a problem hiding this comment.
Despite our one comment left - LGTM!
Was generative AI tooling used to co-author this PR?
Claude Opus 4.7
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.