PR-triage skill: promote likely-addressed PRs with reviewer ping#65916
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 27, 2026
Merged
Conversation
Adds a new suggested action `mark-ready-with-ping` for the case that today routes to `ping`: a PR's only outstanding signal is unresolved review threads from collaborators. When a cheap batch-query heuristic shows the author has likely addressed each thread (in-thread reply or post-comment commit, plus the latest commit post-dates the most recent unresolved thread), the skill proposes promoting the PR to `ready for maintainer review` and posting a single ping comment that invites the original reviewer(s) to confirm and resolve their threads. The heuristic is conservative: false-negatives degrade to the existing plain `ping` behaviour; false-positives self-correct on the next round-trip because the comment explicitly invites the reviewer to push back. The new action shares the same mandatory pre-mutation guard as `mark-ready` (refuse if any workflow run is in `action_required` for the PR's head SHA). Files touched: - `fetch-and-batch.md`: widen `reviewThreads.nodes.comments` from `first: 1` to `first: 5` so the heuristic can see in-thread author replies without per-PR follow-up queries. - `classify.md`: document the sub-flag `unresolved_threads_only_likely_addressed`; update the required-fields checklist for the `deterministic_flag` row. - `suggested-actions.md`: split the unresolved-threads-only rule into two; add a "Choosing between ping and mark-ready-with-ping" section. - `actions.md`: add the `mark-ready-with-ping` action recipe; extend the order-of-operations recap. - `comment-templates.md`: add the `mark-ready-with-ping` body template; add the new template to the AI-attribution-footer always-include list. - `SKILL.md`: extend Golden rule 1b so the workflow-approval guard explicitly covers `mark-ready-with-ping`; add the new action to the Step 3 default-action table and Step 4 group ordering. - `interaction-loop.md`: insert the new group ahead of the plain `mark-ready` group so all label-add proposals run back-to-back; add a safe override (`mark-ready-with-ping → ping`); extend the session summary.
potiuk
requested review from
amoghrajesh,
ashb,
choo121600,
jason810496,
jscheffl,
kaxil and
shahar1
as code owners
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-2-test
1 task
potiuk
removed
the
backport-to-v3-2-test
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new suggested action
mark-ready-with-pingfor the casethat today routes to plain
ping: a PR's only outstandingsignal is unresolved review threads from collaborators. When a
cheap batch-query heuristic shows the author has likely
addressed each thread (in-thread reply or post-comment commit,
plus the latest commit post-dates the most recent unresolved
thread), the skill proposes promoting the PR to
ready for maintainer reviewand posting a single ping commentthat invites the original reviewer(s) to confirm and resolve
their threads.
The heuristic is conservative: false-negatives degrade to the
existing plain
pingbehaviour; false-positives self-correcton the next round-trip because the comment explicitly invites
the reviewer to push back. The new action shares the same
mandatory pre-mutation guard as
mark-ready(refuse if anyworkflow run is in
action_requiredfor the PR's head SHA).Files touched:
fetch-and-batch.md: widenreviewThreads.nodes.commentsfrom
first: 1tofirst: 5so the heuristic can seein-thread author replies without per-PR follow-up queries.
classify.md: document theunresolved_threads_only_likely_addressedsub-flag; updatethe required-fields checklist.
suggested-actions.md: split the unresolved-threads-onlyrule into two; new "Choosing between ping and
mark-ready-with-ping" section.
actions.md: newmark-ready-with-pingrecipe; extend theorder-of-operations recap.
comment-templates.md: newmark-ready-with-pingbody;added to the AI-attribution-footer always-include list.
SKILL.md: extend Golden rule 1b so the workflow-approvalguard explicitly covers
mark-ready-with-ping; add to theStep 3 default-action table and Step 4 group ordering.
interaction-loop.md: insert the new group ahead of plainmark-readyso all label-add proposals run back-to-back;add safe override (
mark-ready-with-ping → ping); extendthe session summary.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.7 (1M context) following the guidelines