Skip to content

Add support of different graph directions in the Asset graph view.#65948

Merged
bbovenzi merged 10 commits into
apache:mainfrom
smit-makadia-infocusp:feature/add-direction-asset-graph
May 5, 2026
Merged

Add support of different graph directions in the Asset graph view.#65948
bbovenzi merged 10 commits into
apache:mainfrom
smit-makadia-infocusp:feature/add-direction-asset-graph

Conversation

@smit-makadia-infocusp
Copy link
Copy Markdown
Contributor

@smit-makadia-infocusp smit-makadia-infocusp commented Apr 27, 2026


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Closes #56095.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 27, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@smit-makadia-infocusp smit-makadia-infocusp marked this pull request as draft April 27, 2026 12:39
@smit-makadia-infocusp smit-makadia-infocusp marked this pull request as ready for review April 27, 2026 12:56
@bbovenzi
Copy link
Copy Markdown
Contributor

Thanks.

  1. Let's extract the direction dropdown to its own shared component that we reuse for the asset and dag graphs
  2. Could you provide a quick screenshot?

@bbovenzi bbovenzi added this to the Airflow 3.2.2 milestone Apr 27, 2026
@smit-makadia-infocusp
Copy link
Copy Markdown
Contributor Author

Thanks.

  1. Let's extract the direction dropdown to its own shared component that we reuse for the asset and dag graphs
  2. Could you provide a quick screenshot?
  1. Done.
  2. Here's a couple of screenshots for asset graph view with direction options and graph in a different direction.
Screenshot from 2026-04-28 13-05-03 Screenshot from 2026-04-28 13-05-40

Comment thread airflow-core/src/airflow/ui/src/components/Graph/DirectionDropdown.tsx Outdated
@bbovenzi bbovenzi added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 30, 2026
@bbovenzi
Copy link
Copy Markdown
Contributor

Looks like some linting issues. Run pnpm format locally

@smit-makadia-infocusp
Copy link
Copy Markdown
Contributor Author

Looks like some linting issues. Run pnpm format locally

Done.

Comment thread airflow-core/src/airflow/ui/src/layouts/Details/Graph/Graph.tsx Outdated
Comment thread airflow-core/src/airflow/ui/src/pages/Asset/AssetGraph.tsx Outdated
Comment thread airflow-core/src/airflow/ui/src/components/Graph/useGraphLayout.ts Outdated
@bbovenzi bbovenzi merged commit 7821429 into apache:main May 5, 2026
83 checks passed
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 5, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 7821429 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@smit-makadia-infocusp smit-makadia-infocusp deleted the feature/add-direction-asset-graph branch May 6, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support different graph directions in the Asset graph view

3 participants