[v3-2-test] Update search parameters to better leverage DB indexes#65964
Merged
Conversation
* API: Use prefix matching for REST list search parameters Search query parameters on list endpoints now use prefix matching (LIKE 'value%') instead of substring search, which allows the database to use indexes more effectively. This is a breaking change for clients that relied on matching arbitrary substrings in names and identifiers. Regenerate OpenAPI specs and UI client types accordingly. * API: Add index-friendly *_prefix_pattern query params (non-breaking) Keep the existing *_pattern substring filters unchanged and add parallel *_prefix_pattern variants that use a B-tree-friendly range comparison, so large deployments can filter list endpoints without paying for a full table scan. Drop custom TaskDisplayName substring class; replace feature newsfragment with significant Full-match on ``coalesce(...)`` can't use an index anyway, so the custom ``_TaskDisplayNamePatternParam`` class adds nothing over a plain ``_SearchParam``: use ``search_param_factory`` directly for the substring variant and keep the custom prefix variant since the split on ``IS NULL`` is what makes the B-tree index apply. Swap 64963.feature for 64963.significant to flag the user-visible UI change (search-as-you-type is now prefix-based, not substring). Fix CI Fix CI * UI: Fix connections search e2e fixtures for prefix-match API The fixtures had names like search_production_<ts> but the UI search now hits the prefix-match API (connection_id_prefix_pattern). Move the environment word to the front (production_search_<ts>, staging_search_<ts>, development_search_<ts>) so "production" is a valid prefix. (cherry picked from commit 7336ed4)
pierrejeambrun
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:API
vatsrahul1001
added
the
type:misc/internal
vatsrahul1001
pushed a commit
that referenced
this pull request
May 20, 2026
* API: Use prefix matching for REST list search parameters Search query parameters on list endpoints now use prefix matching (LIKE 'value%') instead of substring search, which allows the database to use indexes more effectively. This is a breaking change for clients that relied on matching arbitrary substrings in names and identifiers. Regenerate OpenAPI specs and UI client types accordingly. * API: Add index-friendly *_prefix_pattern query params (non-breaking) Keep the existing *_pattern substring filters unchanged and add parallel *_prefix_pattern variants that use a B-tree-friendly range comparison, so large deployments can filter list endpoints without paying for a full table scan. Drop custom TaskDisplayName substring class; replace feature newsfragment with significant Full-match on ``coalesce(...)`` can't use an index anyway, so the custom ``_TaskDisplayNamePatternParam`` class adds nothing over a plain ``_SearchParam``: use ``search_param_factory`` directly for the substring variant and keep the custom prefix variant since the split on ``IS NULL`` is what makes the B-tree index apply. Swap 64963.feature for 64963.significant to flag the user-visible UI change (search-as-you-type is now prefix-based, not substring). Fix CI Fix CI * UI: Fix connections search e2e fixtures for prefix-match API The fixtures had names like search_production_<ts> but the UI search now hits the prefix-match API (connection_id_prefix_pattern). Move the environment word to the front (production_search_<ts>, staging_search_<ts>, development_search_<ts>) so "production" is a valid prefix. (cherry picked from commit 7336ed4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64963 to
v3-2-test.Cherry-picked from 7336ed4.
Clean cherry-pick, no conflicts.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines