Fix Edit Connection dialog: add lazyMount to prevent JSON editor infinite loading#65969
Merged
bbovenzi merged 1 commit intoMay 12, 2026
Merged
Conversation
shashbha14
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
bbovenzi
added
the
backport-to-v3-2-test
potiuk
added
the
ready for maintainer review
vatsrahul1001
approved these changes
May 12, 2026
Contributor
|
LGTM, @bbovenzi can you review this as well? |
bbovenzi
approved these changes
May 12, 2026
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 12, 2026
… editor infinite loading (apache#65969) (cherry picked from commit 2064a76) Co-authored-by: Shashwati Bhattacharyaa <166847329+shashbha14@users.noreply.github.com> Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 12, 2026
… editor infinite loading (apache#65969) (cherry picked from commit 2064a76) Co-authored-by: Shashwati Bhattacharyaa <166847329+shashbha14@users.noreply.github.com> Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65954
'EditConnectionButton' was missing 'lazyMount' and 'unmountOnExit' on 'Dialog.Root', causing the Monaco JSON editor to mount hidden with zero dimensions and get stuck on "Loading...".
Added both props to match
AddConnectionButtonwhich works correctly.