Skip to content

Fix Monaco JSON editor loading in UI#65990

Open
shaealh wants to merge 2 commits intoapache:mainfrom
shaealh:shaealh/65954-monaco-json-loading
Open

Fix Monaco JSON editor loading in UI#65990
shaealh wants to merge 2 commits intoapache:mainfrom
shaealh:shaealh/65954-monaco-json-loading

Conversation

@shaealh
Copy link
Copy Markdown
Contributor

@shaealh shaealh commented Apr 28, 2026

Fixes #65954

Configures Monaco to use bundled editor and JSON workers instead of relying on the default loader path. This prevents JSON editors/viewers from getting stuck on Loading... in packaged Airflow UI views such as Connections and XComs.

Tests:

  • corepack pnpm test src/utils/configureMonaco.test.ts
  • corepack pnpm lint
  • corepack pnpm build

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:Scheduler including HA (high availability) scheduler area:task-sdk area:Triggerer area:UI Related to UI/UX. For Frontend Developers. labels Apr 28, 2026
@shaealh shaealh force-pushed the shaealh/65954-monaco-json-loading branch from 13a1e5b to 546a36e Compare April 28, 2026 03:07
},
};

loader.config({ monaco: monaco as unknown as Monaco });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we shouldn't need type-casting like this. But if its necessary then please leave a comment explaining why

Comment thread uv.lock
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be changing the uv.lock

readonly env: ImportMetaEnv;
}

declare module "monaco-editor/esm/vs/editor/editor.api.js" {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a comment on why this is necessary

@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 5, 2026

@shaealh — There are 3 unresolved review thread(s) on this PR from @bbovenzi. Could you either push a fix or reply in each thread explaining why the feedback doesn't apply? Once you believe the feedback is addressed, mark the thread as resolved so the reviewer isn't re-pinged needlessly. Thanks!


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

uv.lock on main just moved via commit c6bdb91 and this PR currently conflicts.

Quickest fix:

git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-lease

Automated nudge — ignore if you're not ready to rebase. This comment is updated in place on future uv.lock bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:Scheduler including HA (high availability) scheduler area:task-sdk area:Triggerer area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webserver edit connections Extra Fields JSON doesn't load

3 participants