[Draft] Lazy load Slack SDK In Slack provider#66028
Conversation
c2b77a8 to
51b259a
Compare
SameerMesiah97
left a comment
There was a problem hiding this comment.
As evidenced by the numerous CI failures, it looks like this PR has broken patching in multiple tests. I would ensure that patching is applied correctly for each runtime codepath under your new implementation. Until then, it would be best to keep this as a draft PR.
|
@SameerMesiah97 really sorry about that, I did the work on my laptop and couldn't get the CI working locally, not even |
No need to apologize. This was just a heads up because a maintainer would likely ask you to convert it to draft anyway. Take as much time as you need. |
|
@dwreeves Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
|
@dwreeves This draft PR has been inactive for 7 days since the last triage comment and no response from the author. Closing to keep the queue clean. You are welcome to reopen this PR when you resume work, or to open a new one addressing the issues previously raised. There is no rush — take your time.Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
Lazy-load
slack_sdkimports to reduce memory footprint of both importing the Slack hooks and also usage (since some of the memory footprint is specific to the async SDK, which isn't always used even during execution contexts).Was generative AI tooling used to co-author this PR?
No, the code written by hand, but I used generative AI to write the benchmarking script in the issue #66025.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.