[chart/v1-2x-test] fix(helm-chart): fix go-template if statements for log groomer retention values (#66012)#66050
Merged
Conversation
… log groomer retention values (#66012) * fix(helm-chart): fix go-template if statements for log groomer retention values * refactor(helm-chart): simplify go-template if statements for log groomer retention values as empty string is already excluded via JSON schema * test(helm-chart): fix log groomer helm-tests by adding test for logGroomerSidecar.retentionMinutes (cherry picked from commit 56b364b) Co-authored-by: n-badtke-cg <201763987+n-badtke-cg@users.noreply.github.com>
jscheffl
requested review from
bugraoz93,
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(helm-chart): fix go-template if statements for log groomer retention values
refactor(helm-chart): simplify go-template if statements for log groomer retention values as empty string is already excluded via JSON schema
test(helm-chart): fix log groomer helm-tests by adding test for logGroomerSidecar.retentionMinutes
(cherry picked from commit 56b364b)
Co-authored-by: n-badtke-cg 201763987+n-badtke-cg@users.noreply.github.com