Enable PT007 rule to apache.kafka Provider test#66147
Merged
jason810496 merged 1 commit intoapache:mainfrom May 2, 2026
Merged
Enable PT007 rule to apache.kafka Provider test#66147jason810496 merged 1 commit intoapache:mainfrom
jason810496 merged 1 commit intoapache:mainfrom
Conversation
jason810496
approved these changes
Apr 30, 2026
5ce5313 to
23b6a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 3
PT007violations inproviders/apache/kafka/tests/unit/apache/kafka/operators/test_consume.pyby convertingpytest.mark.parametrizevalue rows fromlisttotuple, following ruff's defaultparametrize-values-row-type = "tuple".This is one step in the gradual cleanup toward removing
PT007from the ignore list inpyproject.toml, mirroring the same approach used for the recently completedPT006series.Why this change
PT007flags cases where parameter rows in@pytest.mark.parametrize(...)uselistinstead oftuple. The rule treats this as a readability / consistency issue rather than a correctness one — pytest accepts both — so the change is purely stylistic but enforces a consistent convention across the codebase.Reference: ruff PT007 — pytest-parametrize-values-wrong-type (derived from
flake8-pytest-style).