Skip to content

Fix consistent return response from PubSubPullOperator#66156

Merged
shahar1 merged 1 commit intoapache:mainfrom
VladaZakharova:fix-deff-mode-for-pub-sub-pull-op
May 5, 2026
Merged

Fix consistent return response from PubSubPullOperator#66156
shahar1 merged 1 commit intoapache:mainfrom
VladaZakharova:fix-deff-mode-for-pub-sub-pull-op

Conversation

@MaksYermak
Copy link
Copy Markdown
Contributor

In this PR #42080 the issue #41877 was fixed only for PubSubPullSensor. But because PubSubPullSensor and PubSubPullOperator both use the PubsubPullTrigger. This issue exists for PubSubPullOperator as well.

In the current PR I have applied the same solution for PubSubPullOperator.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@MaksYermak MaksYermak requested a review from shahar1 as a code owner April 30, 2026 13:17
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Apr 30, 2026
@VladaZakharova
Copy link
Copy Markdown
Contributor

Hi @shahar1 !
This PR is a part of new upcoming change in google provider and i was hoping it will be released in the nearest release (5th May). Can you please take a look and maybe merge it, so we can try to aim till the release day? :)
thank you in advance!

Comment thread providers/google/src/airflow/providers/google/cloud/operators/pubsub.py Outdated
Comment thread providers/google/src/airflow/providers/google/cloud/operators/pubsub.py Outdated
Comment thread providers/google/src/airflow/providers/google/cloud/operators/pubsub.py Outdated
@MaksYermak MaksYermak force-pushed the fix-deff-mode-for-pub-sub-pull-op branch from 6a82657 to 61a3307 Compare May 4, 2026 14:53
Copy link
Copy Markdown
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the change, but would like to have @shahar1 take another look :)

@shahar1 shahar1 merged commit 23fbf87 into apache:main May 5, 2026
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants