Fix ASYNC110 violation in edge3 worker#66192
Merged
potiuk merged 1 commit intoapache:mainfrom May 1, 2026
Merged
Conversation
PR apache#66144 added a `while job.is_running: await sleep(0.1)` polling loop to ensure the supervisor task has fully ended after results were grabbed from the queue. This trips ruff's ASYNC110 lint and is now failing the static-checks job on every PR. Apply the same pattern used in PR apache#66157 for RedshiftDataTrigger: refactor to `while True: if not <cond>: break; await sleep(...)`. Same behaviour, ASYNC110-clean. The proper fix (asyncio.Event signalled by the supervisor on completion) is a larger change and can land separately.
boring-cyborg
Bot
added
area:providers
provider:edge
potiuk
approved these changes
May 1, 2026
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #66144 added a
while job.is_running: await sleep(0.1)polling loop inproviders/edge3/src/airflow/providers/edge3/cli/worker.py:557to ensure the supervisor task has fully ended after results were grabbed from the queue. This trips ruff's ASYNC110 lint and is currently failing the static-checks job on every PR built againstmain(e.g., run 25191627167).Fix
Apply the same pattern PR #66157 used for
RedshiftDataTrigger: refactorwhile X: await sleep(...)towhile True: if not X: break; await sleep(...). Same behaviour, ASYNC110-clean.The proper fix (signalling completion via
asyncio.Eventfrom the supervisor instead of polling) is a larger refactor and can land separately.Why this matters now
Every PR's
CI image checks / Static checksjob currently fails on this rule.Was generative AI tooling used to co-author this PR?