Skip to content

Fix launcher RBAC for fully-qualified executors#66208

Merged
jscheffl merged 1 commit into
apache:mainfrom
henry3260:chart-executor-path-rbac
May 1, 2026
Merged

Fix launcher RBAC for fully-qualified executors#66208
jscheffl merged 1 commit into
apache:mainfrom
henry3260:chart-executor-path-rbac

Conversation

@henry3260
Copy link
Copy Markdown
Contributor

Why

The chart schema accepts fully-qualified executor class paths in executor, and the chart writes that value directly into Airflow config.

Airflow runtime also treats fully-qualified executor paths as valid, but the po launcher RoleBindings only matched short executor names such as CeleryExecutor and KubernetesExecutor.

As a result, valid configurations like airflow.providers.celery.executors.celery_executor.CeleryExecutor could
miss the expected scheduler or worker subjects in the generated RoleBinding,
which breaks the RBAC needed to launch pods or jobs.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:helm-chart Airflow Helm Chart label May 1, 2026
@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label May 1, 2026
@jscheffl jscheffl added this to the Airflow Helm Chart 1.22.0 milestone May 1, 2026
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix!

I assume the change will not be able to be directly back-ported to 1.x branch but let's try...

@jscheffl jscheffl merged commit 8f5ac08 into apache:main May 1, 2026
105 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

jscheffl pushed a commit that referenced this pull request May 1, 2026
#66240)

(cherry picked from commit 8f5ac08)

Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260 henry3260 deleted the chart-executor-path-rbac branch May 1, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants