Skip to content

Fix deprecation warnings for workers.logGroomerSidecar#66238

Merged
jscheffl merged 1 commit into
apache:chart/v1-2x-testfrom
Miretpl:fix-deprecation-warnings
May 1, 2026
Merged

Fix deprecation warnings for workers.logGroomerSidecar#66238
jscheffl merged 1 commit into
apache:chart/v1-2x-testfrom
Miretpl:fix-deprecation-warnings

Conversation

@Miretpl
Copy link
Copy Markdown
Contributor

@Miretpl Miretpl commented May 1, 2026

Reverts part of #66012, which introduced deprecation warning generation for non-default values, so e.g. users who are not using these options would see the deprecation warnings during chart deployment.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl
Copy link
Copy Markdown
Contributor

jscheffl commented May 1, 2026

Was this only in 1.x line a problem?

@jscheffl jscheffl merged commit e06b4e5 into apache:chart/v1-2x-test May 1, 2026
2 checks passed
@Miretpl
Copy link
Copy Markdown
Contributor Author

Miretpl commented May 1, 2026

Ah, did a couple of things at once, and I took the wrong branch. Do you think that a cherry picker will work from 1.2x to main for this? 🤔 If not, I will open the same PR for the main

@Miretpl Miretpl deleted the fix-deprecation-warnings branch May 1, 2026 22:01
@jscheffl
Copy link
Copy Markdown
Contributor

jscheffl commented May 1, 2026

Ah, did a couple of things at once, and I took the wrong branch. Do you think that a cherry picker will work from 1.2x to main for this? 🤔 If not, I will open the same PR for the main

No worry, forward ported in #66243 - just via git cherry-pick...

shahar1 pushed a commit that referenced this pull request May 2, 2026
Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@n-badtke-cg
Copy link
Copy Markdown
Contributor

Thank you and sorry for the additional work I caused 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants