Skip to content

[AIRFLOW-6034] Fix Deprecated Elasticsearch configs on Master#6628

Merged
kaxil merged 1 commit intoapache:masterfrom
kaxil:fix-elastic
Nov 22, 2019
Merged

[AIRFLOW-6034] Fix Deprecated Elasticsearch configs on Master#6628
kaxil merged 1 commit intoapache:masterfrom
kaxil:fix-elastic

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Nov 21, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This was already fixed in v1-10-* branches

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

This has already been fixed in v1-10-* branches
@kaxil kaxil requested a review from ashb November 21, 2019 18:21
@kaxil
Copy link
Member Author

kaxil commented Nov 21, 2019

I had fixed incorrect label in #6620 but I didn't know that they were wrong i. key were actually values and vice versa.

@codecov-io
Copy link

Codecov Report

Merging #6628 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6628      +/-   ##
==========================================
- Coverage    83.8%   83.25%   -0.55%     
==========================================
  Files         669      669              
  Lines       37564    37548      -16     
==========================================
- Hits        31479    31261     -218     
- Misses       6085     6287     +202
Impacted Files Coverage Δ
airflow/configuration.py 89.13% <ø> (-3.63%) ⬇️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 77.14% <0%> (-21.43%) ⬇️
airflow/utils/sqlalchemy.py 86.44% <0%> (-6.78%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8b8cf...db94e5a. Read the comment docs.

@kaxil kaxil merged commit b0bdd37 into apache:master Nov 22, 2019
@kaxil kaxil deleted the fix-elastic branch November 22, 2019 15:02
@kaxil kaxil changed the title [AIRFLOW-6034] Fix Deprecation Elasticsearch configs on Master [AIRFLOW-6034] Fix Deprecated Elasticsearch configs on Master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants