feat: adopt apache/airflow-steward via snapshot+overrides mechanism#66319
Closed
potiuk wants to merge 1 commit into
Closed
feat: adopt apache/airflow-steward via snapshot+overrides mechanism#66319potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
Apache Airflow becomes an adopter of the [apache/airflow-steward](https://github.com/apache/airflow-steward) framework, which ships maintainer-facing skills as a project- agnostic library. The previous in-repo copies of the PR-triage / PR-stats / maintainer-review skills are replaced by the framework's renamed `pr-management-*` family delivered through the framework's snapshot + agentic-overrides mechanism. What lands committed in this PR - .github/skills/setup-steward/ + .claude/skills/setup-steward symlink (matching airflow's existing .claude/skills/<n> -> .github/skills/<n>/ double-symlink convention) — the framework's bootstrap skill, copied from apache/airflow-steward main. This is the only framework artefact airflow commits. - .gitignore — gitignore .apache-steward/ (the framework snapshot — a build artefact, refreshed by /setup-steward), remove the explicit pr-triage/pr-stats/maintainer-review exemptions (they're gone), add a setup-steward exemption, and gitignore the framework's runtime symlinks under .github/skills/. - .apache-steward.lock — pins the snapshot to a specific framework commit. Updated by /setup-steward upgrade. - .apache-steward-overrides/README.md — the override-directory scaffold. Adopter-specific deviations from framework workflows live here, committed. - .markdownlintignore — skip the framework's skill markdown files (they follow the framework's own markdownlint convention; already linted upstream). - CLAUDE.md / AGENTS.md — short adoption note explaining the bootstrap flow ("tell your agent: adopt apache-steward in this repo"). - contributing-docs/25_maintainer_pr_triage.md — top-of-doc notice that skills now live in the framework, plus path updates from pr-triage/pr-stats/maintainer-review to the pr-management-* names. What got deleted - .github/skills/pr-triage/, .github/skills/pr-stats/, .github/skills/maintainer-review/ (the in-repo copies — now delivered via the framework as pr-management-{triage,stats,code-review}). - The corresponding .claude/skills/ symlinks. What stays untouched - .github/skills/aip-user-stories/, .github/skills/airflow-translations/, .github/skills/prepare-providers-documentation/ (airflow-only skills that don't migrate to the framework). - The corresponding .claude/skills/ symlink for aip-user-stories. Bootstrap flow on a fresh clone $ git clone <fork> $ cd airflow $ # tell your agent: "adopt apache-steward in this repo" $ # OR invoke /setup-steward directly /setup-steward downloads the framework into .apache-steward/ (gitignored), creates gitignored symlinks under .github/skills/<n> -> .apache-steward/.claude/skills/<n>/ for every framework skill the project uses, and refreshes both on /setup-steward upgrade. Replaces the closed apache#66283 (the original submodule- based adoption attempt) per the design pivot documented in apache/airflow-steward#38. Generated-by: Claude Code (Claude Opus 4.7)
Contributor
|
Hello @potiuk |
Member
Author
|
No no... I will have to redo it |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apache Airflow becomes an adopter of the
apache/airflow-stewardframework using the snapshot + agentic-overrides adoption mechanism. The previous in-repo PR-skill copies (pr-triage,pr-stats,maintainer-review) are replaced by the framework's renamedpr-management-*family delivered through the framework.This supersedes the closed #66283, which used a git-submodule design that we ultimately rejected.
How adoption works
The framework lives in a gitignored
.apache-steward/directory in this repo, refreshed by the framework's ownsetup-stewardskill. The only framework artefact this PR commits is that bootstrap skill itself — at.github/skills/setup-steward/(matching airflow's existing.claude/skills/<n>→.github/skills/<n>/double-symlink convention).On a fresh clone, the framework's other skills are not yet on disk. To populate them:
The
setup-stewardskill then:.apache-steward/(gitignored, refreshed via/setup-steward upgrade)..github/skills/<framework-skill>/→.apache-steward/.claude/skills/<framework-skill>/..claude/skills/so Claude Code picks them up.What lands committed
.github/skills/setup-steward/(+.claude/skills/setup-stewardsymlink).gitignore.apache-steward/, the runtime framework symlinks; remove old in-repo skill exemptions; addsetup-stewardexemption..apache-steward.lock84852ca1a0…. Updated by/setup-steward upgrade..apache-steward-overrides/README.md.markdownlintignoreCLAUDE.md(=AGENTS.md)contributing-docs/25_maintainer_pr_triage.mdpr-triage→pr-management-triageetc.What got deleted
.github/skills/pr-triage/,.github/skills/pr-stats/,.github/skills/maintainer-review/— replaced bypr-management-{triage,stats,code-review}from the framework..claude/skills/symlinks.What stays untouched
.github/skills/aip-user-stories/,.github/skills/airflow-translations/,.github/skills/prepare-providers-documentation/— airflow-only skills that don't migrate to the framework..claude/skills/aip-user-storiessymlink.Test plan
prek runpasses locally (markdownlint, codespell, license-header, …)setup-stewardskill registers in Claude Code's available-skills (live discovery picks it up).gitignorecorrectly ignores.apache-steward/and the gitignored symlinks/setup-stewardagainst a fresh clone of this branch to verify the end-to-end adoption flowOut of scope
contributing-docs/25_maintainer_pr_triage.mdto reflect the framework'spr-management-*skill structure (steps, decision tables, etc.). This PR does the path renames + top-of-doc notice; a follow-up can do the substantive update once maintainers have run/setup-stewardand read the new framework's skill files.apache/airflow-ssecurity tracker, not from this public upstream).🤖 Generated with Claude Code