Fix task run context crash when DagRun state is expired#66339
Merged
amoghrajesh merged 1 commit intoapache:mainfrom May 4, 2026
Merged
Fix task run context crash when DagRun state is expired#66339amoghrajesh merged 1 commit intoapache:mainfrom
amoghrajesh merged 1 commit intoapache:mainfrom
Conversation
potiuk
approved these changes
May 4, 2026
eladkal
approved these changes
May 4, 2026
ephraimbuddy
approved these changes
May 4, 2026
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 4, 2026
…pache#66339) (cherry picked from commit 403a1eb) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 4, 2026
…pache#66339) (cherry picked from commit 403a1eb) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
What problem are we solving?
After
session.commit(), SQLA expires all ORM instance attributes. Thesafe_extract_from_ormvalidator added in: #63916, reads attributes frominsp.dictto avoidDetachedInstanceError— but expired attributes are absent from__dict__. SinceDagRun._stateis expired after a commit, state is silently dropped from the extracted dict, and pydantic raises aResponseValidationErrorbecausestate: DagRunStateis required.Current behaviour
Tasks fail to enter the running state with:
ResponseValidationError: Field required at ('response', 'dag_run', 'state')Fix
When
_stateis absent frominsp.dictbut the instance is still attached (notinsp.detached), fall back to accessingdata._statedirectly — this triggers SQLA's lazy reload. This guard preserves the original fix: on a genuinely detached instance, direct access wouldraise DetachedInstanceError, so that case is left alone.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.