Fix broken import in TaskHandlerWithCustomFormatter#66357
Open
jfmlima wants to merge 1 commit into
Open
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
d6d21b5 to
98ac485
Compare
`_render_template_to_string` was removed from `airflow.utils.helpers` in apache#54715 but this module was not updated, causing an ImportError at startup when using a custom logging config that references this handler. Use the public `render_template_to_string` from `airflow.sdk.definitions.context` instead.
98ac485 to
be14dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskHandlerWithCustomFormatterfails to import on Airflow 3.2.x because it references the private function_render_template_to_stringfromairflow.utils.helpers, which was removed in #54715.This causes an
ImportErrorat startup for any deployment using a custom logging config that references this handler:Uses the public
render_template_to_stringfromairflow.sdk.definitions.context(where #54715 moved it) instead of the removed private function.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines