[v3-2-test] Distinguish upstream_failed from failed in normal vision (#66324)#66365
Merged
Conversation
…66324) failed (red.600) and upstream_failed (orange.600) currently differ by ~9° hue at near-identical lightness, producing ΔE2000=6.2 — below the "easily distinguishable" threshold even for normal vision (and collapsing to ΔE=0.4 under deuteranopia). Switch upstream_failed to amber.600 (hue ~58°) so the pair clears ΔE>20 in normal vision while keeping upstream_failed/up_for_retry above ΔE=10. (cherry picked from commit a94a38b) Co-authored-by: Stefan Wang <1fannnw@gmail.com> Related: #66323
bbovenzi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
vatsrahul1001
added
changelog:skip
vatsrahul1001
pushed a commit
that referenced
this pull request
May 20, 2026
…66324) (#66365) failed (red.600) and upstream_failed (orange.600) currently differ by ~9° hue at near-identical lightness, producing ΔE2000=6.2 — below the "easily distinguishable" threshold even for normal vision (and collapsing to ΔE=0.4 under deuteranopia). Switch upstream_failed to amber.600 (hue ~58°) so the pair clears ΔE>20 in normal vision while keeping upstream_failed/up_for_retry above ΔE=10. (cherry picked from commit a94a38b) Related: #66323 Co-authored-by: Stefan Wang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failed (red.600) and upstream_failed (orange.600) currently differ by
~9° hue at near-identical lightness, producing ΔE2000=6.2 — below the
"easily distinguishable" threshold even for normal vision (and
collapsing to ΔE=0.4 under deuteranopia). Switch upstream_failed to
amber.600 (hue ~58°) so the pair clears ΔE>20 in normal vision while
keeping upstream_failed/up_for_retry above ΔE=10.
(cherry picked from commit a94a38b)
Co-authored-by: Stefan Wang 1fannnw@gmail.com
Related: #66323