[AIRFLOW-6049] set propagate True when needed in airflow test#6647
Merged
KevinYang21 merged 1 commit intoapache:masterfrom Nov 25, 2019
pingzh:fix-double-test
Merged
[AIRFLOW-6049] set propagate True when needed in airflow test#6647KevinYang21 merged 1 commit intoapache:masterfrom pingzh:fix-double-test
KevinYang21 merged 1 commit intoapache:masterfrom
pingzh:fix-double-test
Conversation
when airflow.task handlers don't have StreamHandler
KevinYang21
approved these changes
Nov 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #6647 +/- ##
==========================================
- Coverage 83.79% 83.47% -0.32%
==========================================
Files 672 672
Lines 37567 37574 +7
==========================================
- Hits 31478 31365 -113
- Misses 6089 6209 +120
Continue to review full report at Codecov.
|
Member
|
@pingzh When/how do you get this logging config set like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when airflow.task handlers don't have StreamHandler
Make sure you have checked all steps below.
Jira
Description
When the log handler of
airflow.taskis already a subclass ofStreamHandler, thepropagate = Truewill double log.Tests
Tested in the CLI run.
Commits
Documentation
@KevinYang21 @saguziel