Skip to content

[AIRFLOW-6049] set propagate True when needed in airflow test#6647

Merged
KevinYang21 merged 1 commit intoapache:masterfrom
pingzh:fix-double-test
Nov 25, 2019
Merged

[AIRFLOW-6049] set propagate True when needed in airflow test#6647
KevinYang21 merged 1 commit intoapache:masterfrom
pingzh:fix-double-test

Conversation

@pingzh
Copy link
Copy Markdown
Contributor

@pingzh pingzh commented Nov 23, 2019

when airflow.task handlers don't have StreamHandler

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6049
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

When the log handler of airflow.task is already a subclass of StreamHandler, the propagate = True will double log.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Tested in the CLI run.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@KevinYang21 @saguziel

when airflow.task handlers don't have StreamHandler
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 23, 2019

Codecov Report

Merging #6647 into master will decrease coverage by 0.31%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6647      +/-   ##
==========================================
- Coverage   83.79%   83.47%   -0.32%     
==========================================
  Files         672      672              
  Lines       37567    37574       +7     
==========================================
- Hits        31478    31365     -113     
- Misses       6089     6209     +120
Impacted Files Coverage Δ
airflow/cli/commands/task_command.py 63.5% <87.5%> (+1.19%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 76.38% <0%> (-22.23%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/utils/dag_processing.py 58.31% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fe14a...91976ba. Read the comment docs.

@KevinYang21 KevinYang21 merged commit 172b46d into apache:master Nov 25, 2019
@ashb
Copy link
Copy Markdown
Member

ashb commented Nov 26, 2019

@pingzh When/how do you get this logging config set like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants