feat(e2e): add waitForAllDialogsClosed method to handle dialog backdrops#66489
Merged
Conversation
bbovenzi
approved these changes
May 7, 2026
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The should delete a connection Playwright test was consistently failing on WebKit (passes on Chromium/Firefox).
The issue was not a timeout problem. The dialog backdrop never unmounts and remains in the DOM with data-state="closed", blocking pointer events.
Root cause
Chakra v3 / Ark UI waits for animationend to unmount the backdrop, but WebKit drops this event when nested portals are present (combobox + Monaco editor in this dialog).
Fix
Add BasePage.waitForAllDialogsClosed() to ensure no dialog backdrops remain Call it after save and delete actions Remove the 30s timeout workaround
Was generative AI tooling used to co-author this PR?
claude opus 4.7
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.