Skip to content

feat(e2e): add waitForAllDialogsClosed method to handle dialog backdrops#66489

Merged
bbovenzi merged 1 commit into
apache:mainfrom
choo121600:fix-e2e-connection
May 7, 2026
Merged

feat(e2e): add waitForAllDialogsClosed method to handle dialog backdrops#66489
bbovenzi merged 1 commit into
apache:mainfrom
choo121600:fix-e2e-connection

Conversation

@choo121600
Copy link
Copy Markdown
Member

The should delete a connection Playwright test was consistently failing on WebKit (passes on Chromium/Firefox).

The issue was not a timeout problem. The dialog backdrop never unmounts and remains in the DOM with data-state="closed", blocking pointer events.

Root cause

Chakra v3 / Ark UI waits for animationend to unmount the backdrop, but WebKit drops this event when nested portals are present (combobox + Monaco editor in this dialog).

Fix

Add BasePage.waitForAllDialogsClosed() to ensure no dialog backdrops remain Call it after save and delete actions Remove the 30s timeout workaround


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    claude opus 4.7

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@choo121600 choo121600 requested a review from vatsrahul1001 as a code owner May 6, 2026 19:07
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 6, 2026
@bbovenzi bbovenzi merged commit a3e93f8 into apache:main May 7, 2026
83 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants